Open
Conversation
This is just copy-paste from spdk-common-tests.yml. Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@nutanix.com>
Just small renames to match scheme from other workflows. Only functional change is pattern for pulling artifacts from all workflows, that will now include nvmf-phy job. The pattern so far seems to be shaping up 'who-job-type-of-test-what-enviroment-autotest', ex: common-job-nvmf-tcp-vm-autotest common-job-release-build-gcc-container-autotest hpe-job-nvmf-rdma-phy-autotest Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@nutanix.com>
mhae
approved these changes
Apr 2, 2025
Contributor
mhae
left a comment
mhae
left a comment
There was a problem hiding this comment.
Thank you! That was bugging me as well.
glimchb
approved these changes
Apr 4, 2025
Contributor
glimchb
left a comment
glimchb
left a comment
There was a problem hiding this comment.
is autotest at the end add anything useful ? can we remove it across all ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just small renames to match scheme from other workflows. Only functional change is pattern for pulling artifacts from all workflows, that will now include nvmf-phy job.
The pattern so far seems to be shaping up 'who-job-type-of-test-what-enviroment-autotest', ex:
phy-autotestis used due to real hardware being under test, in contrast to emulated devices. Even if the execution environment is a VM with passed VFs.